Fix the server startup issue and fix the build not failing issue#1735
Fix the server startup issue and fix the build not failing issue#1735daneshk merged 5 commits intoballerina-platform:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1735 +/- ##
=============================================
+ Coverage 30.74% 80.20% +49.45%
- Complexity 0 56 +56
=============================================
Files 72 77 +5
Lines 5428 5628 +200
Branches 1100 1148 +48
=============================================
+ Hits 1669 4514 +2845
+ Misses 3599 696 -2903
- Partials 160 418 +258 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| serverConnectorFuture.sync(); | ||
| } catch (Exception ex) { | ||
| return MessageUtils.getConnectorError(new StatusRuntimeException(Status | ||
| throw MessageUtils.getConnectorError(new StatusRuntimeException(Status |
There was a problem hiding this comment.
Is there any specific reason to throw here instead of return similar to other places?
There was a problem hiding this comment.
When the backend server had an error at startup, return was treated as a normal exit rather than an error exit. The grpc build was passing, though tests were not run properly.
3 participants
Purpose
Fixes: ballerina-platform/ballerina-library#8568
Examples
Checklist